JBPM-10199: Mark Async nodes as finished at the SVG when process inst… #3005

nmirasch · 2023-12-20T18:43:21Z

…ance is aborted

jira:https://issues.redhat.com/browse/JBPM-10199

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…ance is aborted

nmirasch · 2023-12-20T18:46:55Z

Jenkins run fdb

sonarcloud · 2023-12-20T21:05:05Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

domhanak · 2024-01-23T08:54:18Z

...-server-services-jbpm-ui/src/main/java/org/kie/server/services/jbpm/ui/ImageServiceBase.java

@@ -144,8 +144,7 @@ public String getActiveProcessImage(String containerId, long procInstId, String
                    fullLogs.stream()
                            .filter(nodeInstanceDesc ->
                                            (((org.jbpm.kie.services.impl.model.NodeInstanceDesc) nodeInstanceDesc).getType() == NodeInstanceLog.TYPE_ASYNC_ENTER) &&
-                                                    fullLogs.stream().noneMatch(nodeInst -> nodeInstanceDesc.getNodeId().equals(nodeInst.getNodeId())
-                                                            && (((org.jbpm.kie.services.impl.model.NodeInstanceDesc) nodeInst).getType() == NodeInstanceLog.TYPE_EXIT)))


@nmirasch @fjtirado could you please share a brief explanation about why we did check by type also?

I see this comment // Async active nodes don't have any related completed node instance

@domhanak before this change it only checked that the async node has an type_exit log to include it as an active one. Now it checks that it's not in the finished ones (including Exited, Aborted, Skipped and Obsolete) to be included as an active node and painted properly.

Thank you! I am setting up rhpam to test the fix.

domhanak · 2024-01-23T13:02:55Z

jenkins do fdb

domhanak · 2024-01-23T13:34:01Z

jenkins do fdb

domhanak · 2024-01-23T17:56:15Z

jenkins do fdb

domhanak · 2024-01-29T07:40:07Z

@nmirasch My current end result is this:

Start
Abort via REST

Could you please confirm this is expected? I am a bit confused as the issue states the Human Task should have Blue Borders but it doesn't.

Another thing I noticed is a strange behavior with 2 async nodes in succesion:

No blue border anywhere. Any idea why?

From my side it looks good, the aborted process is on End Node and that makes sense.

nmirasch · 2024-01-30T18:23:32Z

@domhanak the weird result that I wasn't able to reproduce, is that blue border color (active nodes) after aborting the instance. I tried aborting it via rest and from the BC with the same results, no blue color anywhere. The expected node colors at the diagram are:

Border Red: active Async nodes
Border Blue: active nodes
Gray filling and dark border: completed.
If you have more details about how to reproduce the issue you found would be great, Thanks in advanced!

domhanak · 2024-01-31T08:46:21Z

@nmirasch Okay, I will give it another go and let you know.

domhanak

I have confirmed with @nmirasch that this blue bordrer on End state is not related and seems to be a separate issue. After fresh install, I am unable to reproduce it again.

Apologies for the weird issues report but I was able to do reproduce it consistently and did so several times before posting here :D

Approved.

nmirasch · 2024-01-31T09:11:31Z

thanks @domhanak !

…ance is aborted (#3005)

…ance is aborted (#3005) (#3022) Co-authored-by: nmirasch <[email protected]>

…ance is aborted (#3005) (#3023) Co-authored-by: nmirasch <[email protected]>

JBPM-10199: Mark Async nodes as finished at the SVG when process inst…

582a226

…ance is aborted

fjtirado approved these changes Dec 21, 2023

View reviewed changes

domhanak self-requested a review January 8, 2024 12:56

domhanak added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jan 23, 2024

domhanak reviewed Jan 23, 2024

View reviewed changes

domhanak approved these changes Jan 31, 2024

View reviewed changes

nmirasch merged commit cdcb207 into kiegroup:main Jan 31, 2024
9 checks passed

github-actions bot pushed a commit that referenced this pull request Jan 31, 2024

JBPM-10199: Mark Async nodes as finished at the SVG when process inst…

3cbd22b

…ance is aborted (#3005)

github-actions bot mentioned this pull request Jan 31, 2024

[7.67.x] JBPM-10199: Mark Async nodes as finished at the SVG when process inst… #3022

Merged

github-actions bot pushed a commit that referenced this pull request Jan 31, 2024

JBPM-10199: Mark Async nodes as finished at the SVG when process inst…

5786750

…ance is aborted (#3005)

github-actions bot mentioned this pull request Jan 31, 2024

[7.67.x-blue] JBPM-10199: Mark Async nodes as finished at the SVG when process inst… #3023

Merged

nmirasch added a commit that referenced this pull request Jan 31, 2024

JBPM-10199: Mark Async nodes as finished at the SVG when process inst…

8be9cc5

…ance is aborted (#3005) (#3022) Co-authored-by: nmirasch <[email protected]>

nmirasch added a commit that referenced this pull request Jan 31, 2024

JBPM-10199: Mark Async nodes as finished at the SVG when process inst…

47e846d

…ance is aborted (#3005) (#3023) Co-authored-by: nmirasch <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JBPM-10199: Mark Async nodes as finished at the SVG when process inst… #3005

JBPM-10199: Mark Async nodes as finished at the SVG when process inst… #3005

nmirasch commented Dec 20, 2023

nmirasch commented Dec 20, 2023

sonarcloud bot commented Dec 20, 2023

domhanak Jan 23, 2024

domhanak Jan 23, 2024

nmirasch Jan 23, 2024

domhanak Jan 23, 2024

domhanak commented Jan 23, 2024

domhanak commented Jan 23, 2024

domhanak commented Jan 23, 2024

domhanak commented Jan 29, 2024 •

edited

Loading

nmirasch commented Jan 30, 2024

domhanak commented Jan 31, 2024

domhanak left a comment

nmirasch commented Jan 31, 2024

JBPM-10199: Mark Async nodes as finished at the SVG when process inst… #3005

JBPM-10199: Mark Async nodes as finished at the SVG when process inst… #3005

Conversation

nmirasch commented Dec 20, 2023

nmirasch commented Dec 20, 2023

sonarcloud bot commented Dec 20, 2023

Quality Gate passed

domhanak Jan 23, 2024

Choose a reason for hiding this comment

domhanak Jan 23, 2024

Choose a reason for hiding this comment

nmirasch Jan 23, 2024

Choose a reason for hiding this comment

domhanak Jan 23, 2024

Choose a reason for hiding this comment

domhanak commented Jan 23, 2024

domhanak commented Jan 23, 2024

domhanak commented Jan 23, 2024

domhanak commented Jan 29, 2024 • edited Loading

nmirasch commented Jan 30, 2024

domhanak commented Jan 31, 2024

domhanak left a comment

Choose a reason for hiding this comment

nmirasch commented Jan 31, 2024

domhanak commented Jan 29, 2024 •

edited

Loading